msg-stats: add stats() block & add syslog-stats() global stats() option #4337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No news file has been detected. Please write one, if applicable. |
|
Build FAILURE |
|
@kira-syslogng retest this please; |
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
alltilla
added a commit
to alltilla/syslog-ng
that referenced
this pull request
Feb 21, 2023
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
alltilla
force-pushed
the
msg-stats-toggle
branch
from
dd7fb41
to
5f1a344
Compare
alltilla
changed the title
We have a significant number of stats related global options. I am planning to add another one, so I felt like it is time to group these options together. This change breaks the behavior of the old stats() global option, which was an alias for stats-freq(), but it has been deprecated for more than a decade now, I think it is safe to remove it now. The old stats-...() options are still supported for compatibility reasons, but new options will be introduced inside the stats() block. Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
E.g.:
options {
stats(
syslog-stats(no)
);
};
Possible values are:
* yes => force enable
* no => force disable
* auto => let stats(level()) decide (old behavior)
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
alltilla
force-pushed
the
msg-stats-toggle
branch
from
5f1a344
to
d32fed3
Compare
MrAnno
approved these changes
Feb 23, 2023
Genfood
pushed a commit
to Genfood/syslog-ng
that referenced
this pull request
Jun 14, 2023
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global
stats()options blockWe have a significant number of stats related global options. I added another one, so I felt like it is time to group these options together.
This change breaks the behavior of the
old stats()global option, which was an alias forstats-freq(), but it has been deprecated for more than a decade now, I think it is safe to remove it now.The old
stats-...()options are still supported for compatibility reasons, but new options will be introduced inside thestats()block.stats(syslog-stats())It changes the behavior of counting messages based on different syslog-proto fields, like
SEVERITY,FACILITY,HOST, etc...Possible values are:
yes=> force enableno=> force disableauto=> letstats-level()decide (old behavior)Signed-off-by: Attila Szakacs szakacs.attila96@gmail.com