Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in timeutils/cache (syslog-ng#4332) #4334

Merged
merged 1 commit into from Feb 22, 2023
Merged

Fix memory leak in timeutils/cache (syslog-ng#4332) #4334

merged 1 commit into from Feb 22, 2023

Conversation

meeusr
Copy link

@meeusr meeusr commented Feb 17, 2023

Each time a worker thread terminates, the 2 allocated tznames are leaked. Solution is to explicitly deinit the cache from the stop function of the thread.

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

1 similar comment
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@github-actions
Copy link
Contributor

No news file has been detected. Please write one, if applicable.

@bazsi bazsi mentioned this pull request Feb 17, 2023
Closed
@bazsi
Copy link
Collaborator

bazsi commented Feb 17, 2023

Ok to test.

@bazsi
timeutils/cache: Fix memory leak at worker thread termination
93adf68 
Each time a worker thread terminates, the 2 allocated tznames are
leaked. Solution is to explicitly deinit the cache from the stop
function of the thread.

Fixes: syslog-ng#4332

Signed-off-by: Ronny Meeus <ronny.meeus@nokia.com>
@bazsi bazsi merged commit ffb856c into syslog-ng:master Feb 22, 2023
MrAnno added a commit to MrAnno/syslog-ng that referenced this pull request Feb 28, 2023
@MrAnno
news: add bugfix syslog-ng#4334
386f4ac 
Signed-off-by: László Várady <laszlo.varady@anno.io>
Genfood pushed a commit to Genfood/syslog-ng that referenced this pull request Jun 14, 2023
@MrAnno @Genfood
news: add bugfix syslog-ng#4334
17c5764 
Signed-off-by: László Várady <laszlo.varady@anno.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazsi bazsi bazsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meeusr @kira-syslogng @bazsi