Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-network-drivers: Added support for the log-iw-size() option. #4328

Merged

Conversation

kovgeri01
Copy link
Contributor

Added the log-iw-size() option for the default-network-drivers with a default value of 1000. This option need to be adjusted for the TCP and TLS sources when changing the max-connections() option.

fixes #4170

Signed-off-by: Kovacs, Gergo Ferenc kovgeri01@gmail.com

@github-actions
Copy link
Contributor

No news file has been detected. Please write one, if applicable.

kovgeri01 added a commit to kovgeri01/syslog-ng that referenced this pull request Feb 14, 2023
Signed-off-by: Kovacs, Gergo Ferenc <kovgeri01@gmail.com>
Copy link
Collaborator

@alltilla alltilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice for a first PR, good job! :)

I have one minor comment, please consider it. Thanks!

scl/default-network-drivers/plugin.conf Outdated Show resolved Hide resolved
@kovgeri01 kovgeri01 force-pushed the default-network-driver_log-iw-size branch from 3054f6e to ebb960f Compare February 14, 2023 14:30
Added the log-iw-size() option for the default-network-drivers with a default value of 1000.
This option need to be adjusted for the TCP and TLS sources when changing the max-connections() option.

Signed-off-by: Kovacs, Gergo Ferenc <kovgeri01@gmail.com>
@kovgeri01 kovgeri01 force-pushed the default-network-driver_log-iw-size branch from ebb960f to a16707b Compare February 14, 2023 14:33
Signed-off-by: Kovacs, Gergo Ferenc <kovgeri01@gmail.com>
Copy link
Collaborator

@alltilla alltilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS fail is not related to this PR, it fails on master, too.

@alltilla alltilla merged commit 03e2511 into syslog-ng:master Feb 14, 2023
Genfood pushed a commit to Genfood/syslog-ng that referenced this pull request Jun 14, 2023
Signed-off-by: Kovacs, Gergo Ferenc <kovgeri01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default-network-drivers should support log-iw-size
3 participants