New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd-journal: fix --with-systemd-journal=optional mode #4304
systemd-journal: fix --with-systemd-journal=optional mode #4304
Conversation
No news file has been detected. Please write one, if applicable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this as is, I added a small improvement that would have made reviewing this easier but that's optional too.
With that change, this unit would be drastically more readable than it has been a month ago :)
Thanks
Further modifications in the lookup of sd_id128_XXX symbols (that can be presented in separate modules on some OSes e.g. Centos) Signed-off-by: Hofi <hofione@gmail.com>
72c34ce
to
67b9b41
Compare
@bazsi Sorry, I've made a typo in libsystemd-id128.so.0, corrected, and added some logging of the lookup process and possible errors. Hope it's fine now. |
Centos tests are passed too, seems we are fine now |
@kira-syslogng retest this please; |
@bazsi Could you please take a look at this one more (and hopefully the last time) again? |
Further modifications in the lookup of sd_id128_XXX symbols (that can be presented in separate modules on some OSes e.g. Centos)
Signed-off-by: Hofi hofione@gmail.com