systemd-journal: fix --with-systemd-journal=optional mode #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes syslog-ng#4300 that was a regression from syslog-ng#4225. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
|
No news file has been detected. Please write one, if applicable. |
|
Build FAILURE |
HofiOne
approved these changes
Feb 1, 2023
| * See https://github.com/syslog-ng/syslog-ng/issues/4300 for more details. | ||
| */ | ||
|
|
||
| #define VISIBILITY_HIDDEN __attribute__((visibility("hidden"))) |
There was a problem hiding this comment.
this is what I was looking for after I realized that g_module_symbol finds the given symbol in our plugin first not in the module passed as its first parameter that is, in my opinion, a glib bug
alltilla
added a commit
to alltilla/syslog-ng
that referenced
this pull request
Feb 14, 2023
…yslog-ng#4302, syslog-ng#4305, syslog-ng#4313 Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
Genfood
pushed a commit
to Genfood/syslog-ng
that referenced
this pull request
Jun 14, 2023
…yslog-ng#4302, syslog-ng#4305, syslog-ng#4313 Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #4300 that was a regression from #4225.