Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python kubernetes key separator #4213

Merged
merged 2 commits into from Feb 7, 2023

Conversation

bazsi
Copy link
Collaborator

@bazsi bazsi commented Nov 15, 2022

This is a work in progress branch to find a good solution for representing kubernetes metadata that contains dots in JSON keys,
causing our name-value representation to become ambiguous

I don't feel the solution in this PR is right, but we can address this post 4.0, so I am splitting this off from #4173

@github-actions
Copy link
Contributor

No news file has been detected. Please write one, if applicable.

@kira-syslogng
Copy link
Contributor

Build FAILURE

@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2022

This pull request introduces 4 alerts and fixes 2 when merging 3d65cac into 8a397f3 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Module imports itself
  • 1 for Special method has incorrect signature

fixed alerts:

  • 2 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@bazsi bazsi force-pushed the python-kubernetes-key-separator branch from 3d65cac to ed12a13 Compare November 15, 2022 12:35
@kira-syslogng
Copy link
Contributor

Build FAILURE

@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2022

This pull request introduces 4 alerts and fixes 2 when merging ed12a13 into 13c19fa - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Module imports itself
  • 1 for Special method has incorrect signature

fixed alerts:

  • 2 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@MrAnno MrAnno marked this pull request as draft November 17, 2022 14:40
@bazsi bazsi force-pushed the python-kubernetes-key-separator branch 2 times, most recently from 0710188 to 9e24301 Compare February 2, 2023 14:44
@kira-syslogng
Copy link
Contributor

Build FAILURE

Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
…ing to '~'

Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
@bazsi bazsi force-pushed the python-kubernetes-key-separator branch from e6e70eb to 1301f48 Compare February 7, 2023 11:44
@bazsi bazsi changed the title WIP: Python kubernetes key separator Python kubernetes key separator Feb 7, 2023
@bazsi bazsi marked this pull request as ready for review February 7, 2023 11:47
@alltilla alltilla merged commit 1aee98c into syslog-ng:master Feb 7, 2023
15 checks passed
alltilla added a commit to alltilla/syslog-ng that referenced this pull request Feb 14, 2023
MrAnno added a commit that referenced this pull request Feb 14, 2023
Genfood pushed a commit to Genfood/syslog-ng that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants